You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 6, 2023. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The algorithm for mountainsort4 was in ml_ms4alg but has recently been cleaned up and is now in mountainsort4 (https://github.com/magland/mountainsort4, also available on PyPI). This PR changes the reference to ml_ms4alg in spikesorters to mountainsort4.
The build failed with the error AttributeError: module 'dask' has no attribute 'delayed' but I don't get this error when I run pytest locally. Perhaps this is related to the way dask is installed on the CI server? @alejoe91
@alejoe91 I noticed that the cleaned up mountainsort4 package no longer has code for computing the noise overlap quality metric (the mountainsort4_curation function), presumably because all quality metrics are now computed by spiketoolkit. I don't know if this is causing the problem but I will fix this and resubmit
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The algorithm for mountainsort4 was in
ml_ms4algbut has recently been cleaned up and is now inmountainsort4(https://github.com/magland/mountainsort4, also available on PyPI). This PR changes the reference toml_ms4alginspikesorterstomountainsort4.@magland I assume this is OK?